Changed the newsletter present in the footer of Student-Program to a …#31
Closed
mimansha2019 wants to merge 1 commit intokeploy:mainfrom
Closed
Changed the newsletter present in the footer of Student-Program to a …#31mimansha2019 wants to merge 1 commit intokeploy:mainfrom
mimansha2019 wants to merge 1 commit intokeploy:mainfrom
Conversation
…button which helps redirect to Keploy's Docs page
Member
|
Hey @mimansha2019 Thanks for raising this pr. this is a good contribution since it involves a good study of the website. But, unfrotunately we wont be able to merge this pr because we are planning to migrate this code to nextjs, there is an exiwsting pr to do so, once that opr is merged, you can make changes accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Button which helps redirect to Keploy's Docs page
Pull Request Template
Description
I changed the newsletter subscription present in the footer section of the Keploy-Student-Program to a button which redirects the user to Keploy's Docs Website on clicking.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested by running it on my local server, as I saw that the subscribe to newsletter was present twice. To prevent that recurrence, I provided the button, and it works fine, being responsive as well.
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: