Skip to content

Changed the newsletter present in the footer of Student-Program to a …#31

Closed
mimansha2019 wants to merge 1 commit intokeploy:mainfrom
mimansha2019:mimansha
Closed

Changed the newsletter present in the footer of Student-Program to a …#31
mimansha2019 wants to merge 1 commit intokeploy:mainfrom
mimansha2019:mimansha

Conversation

@mimansha2019
Copy link
Copy Markdown

@mimansha2019 mimansha2019 commented Jun 18, 2025

…Button which helps redirect to Keploy's Docs page

Pull Request Template

Description

I changed the newsletter subscription present in the footer section of the Keploy-Student-Program to a button which redirects the user to Keploy's Docs Website on clicking.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I tested by running it on my local server, as I saw that the subscribe to newsletter was present twice. To prevent that recurrence, I provided the button, and it works fine, being responsive as well.

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

…button which helps redirect to Keploy's Docs page
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in student-program

@mimansha2019 mimansha2019 changed the title changed the newsletter present in the footer of Student-Program to a … Changed the newsletter present in the footer of Student-Program to a … Jun 18, 2025
@amaan-bhati
Copy link
Copy Markdown
Member

Hey @mimansha2019 Thanks for raising this pr. this is a good contribution since it involves a good study of the website. But, unfrotunately we wont be able to merge this pr because we are planning to migrate this code to nextjs, there is an exiwsting pr to do so, once that opr is merged, you can make changes accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants